Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Build output not respecting file extensions in import statements #250

Closed
sachaw opened this issue Aug 6, 2023 · 2 comments · May be fixed by lkeff/airhornbot#5
Closed

Bug: Build output not respecting file extensions in import statements #250

sachaw opened this issue Aug 6, 2023 · 2 comments · May be fixed by lkeff/airhornbot#5
Labels
bug Something isn't working

Comments

@sachaw
Copy link
Contributor

sachaw commented Aug 6, 2023

Describe the bug
This library clearly adheres to the ESM requirement for having file extensions present in import/export statements, however that appears to be striped in the build output.

Take the file tslog/dist/esm/index.js for example, the generated output is as follows:

import { BaseLogger } from "./BaseLogger";
import BrowserRuntime from "./runtime/browser/";
import NodeRuntime from "./runtime/nodejs/";
export * from "./interfaces";
export * from "./BaseLogger";
export { BrowserRuntime, NodeRuntime };
...

but should be:

import { BaseLogger } from "./BaseLogger.js";
import BrowserRuntime from "./runtime/browser/index.js";
import NodeRuntime from "./runtime/nodejs/index.js";
export * from "./interfaces.js";
export * from "./BaseLogger.js";
export { BrowserRuntime, NodeRuntime };
...
@sachaw sachaw added the bug Something isn't working label Aug 6, 2023
@terehov
Copy link
Contributor

terehov commented Aug 6, 2023

Thanks! Your fast, that slipped in the yesterday's release. Will fix it now.

terehov added a commit that referenced this issue Aug 6, 2023
@terehov
Copy link
Contributor

terehov commented Aug 6, 2023

Fix: v4.8.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants