Merge pull request #125 from ejose19/ej/excludeNameFromErrorDetails

Exclude error name from "IErrorObject"
fullstack-build · Nov 29, 2021 · 1060bb2 · 1060bb2
2 parents 1e4983a + 29b227b
commit 1060bb2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/LoggerWithoutCallSite.ts b/src/LoggerWithoutCallSite.ts
@@ -456,9 +456,15 @@ export class LoggerWithoutCallSite {
       relevantCallSites.length = stackLimit;
     }
 
+    const {
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
+      name: _name,
+      ...errorWithoutName
+    } = error;
+
     const errorObject: IErrorObject = {
       nativeError: error,
-      details: { ...error },
+      details: { ...errorWithoutName },
       name: error.name ?? "Error",
       isError: true,
       message: error.message,

diff --git a/tests/error.test.ts b/tests/error.test.ts
@@ -55,13 +55,15 @@ describe("Logger: Error with details", () => {
     loggerPretty.warn(error);
     expect(doesLogContain(stdErr, "TestError")).toBeTruthy();
     expect(doesLogContain(stdErr, ".test.ts")).toBeTruthy();
+    expect(doesLogContain(stdErr, "details:")).toBeFalsy();
   });
 
   test("JSON: Error with details (stdErr)", (): void => {
     const error = new TestError("TestError");
     loggerJson.warn(error);
     expect(doesLogContain(stdErr, "TestError")).toBeTruthy();
     expect(doesLogContain(stdErr, ".test.ts")).toBeTruthy();
+    expect(doesLogContain(stdErr, '"details":{}')).toBeTruthy();
   });
 
   test("JSON: Check if call site wrapping is working (Bugfix: #29)", (): void => {