chore: fix PyPi trusted publishing in GitHub Actions #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will not be possible to test without making a release of some kind. |
clintval
commented
Sep 18, 2024
| @@ -124,7 +124,6 @@ jobs: | |||
| uses: softprops/action-gh-release@v2 | |||
| with: | |||
| name: ${{ github.ref_name }} | |||
| body: | | |||
| ${{ needs.draft-changelog.outputs.release_body }} | |||
| body: ${{ needs.make-changelog.outputs.release_body }} | |||
There was a problem hiding this comment.
This appeared to be a bug referencing a job that didn't exist.
Comment on lines
+38
to
+39
| [python-package-badge]: https://github.com/fulcrumgenomics/prymer/workflows/publish_prymer/badge.svg | ||
| [python-package-link]: https://github.com/fulcrumgenomics/prymer/actions/workflows/publish_prymer.yml |
There was a problem hiding this comment.
These links don't exist yet, but will once the first action runs.
|
Looks like it was a transient issue... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 25 25
Lines 1587 1587
Branches 300 300
=======================================
Hits 1545 1545
Misses 23 23
Partials 19 19 ☔ View full report in Codecov by Sentry. |
tfenne
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3
Closes: #24
And the updated PyPi trusted publisher config: