Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility between dependency versions and toolchain #14

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

jdidion
Copy link
Contributor

@jdidion jdidion commented Nov 7, 2023

When channel is set in to a specific version rust-toolchain.toml it fixes that as the version. Typically, what you want to do instead is specify a minimum rust version, which is done using the rust-version parameter in Cargo.toml. The alternative is that you have to fix your dependencies at specific versions that you know are compatible with your rust version (e.g. tempfile = "=3.2.0".

…le' and set msrv via 'rust-version' in Cargo.toml'
@jdidion jdidion requested review from nh13 and tfenne November 7, 2023 18:45
@jdidion jdidion merged commit 3b87b09 into main Nov 7, 2023
@nh13 nh13 deleted the fix/jd-msrv branch November 7, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants