Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to transient MI tag in DuplexConsensusCaller #946

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

clintval
Copy link
Member

@nh13 I'm pretty sure this is what you meant in #493?

I haven't done any benchmarking, but maybe this PR is a free speed-up!

@clintval clintval requested a review from nh13 October 22, 2023 02:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d748c76) 95.60% compared to head (9f6b2e4) 95.60%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         126      126           
  Lines        7308     7308           
  Branches      487      508   +21     
=======================================
  Hits         6987     6987           
  Misses        321      321           
Flag Coverage Δ
unittests 95.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...om/fulcrumgenomics/umi/DuplexConsensusCaller.scala 96.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nh13
Copy link
Member

nh13 commented Oct 22, 2023

It’s a bug nonetheless. Thank you!

@clintval clintval merged commit 2363908 into main Oct 23, 2023
4 checks passed
@clintval clintval deleted the cv_fix_mi_in_ds_caller branch October 23, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants