Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry the Intel deflate test as for some levels it's close to equal time #757

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Retry the Intel deflate test as for some levels it's close to equal time #757

merged 3 commits into from
Jan 11, 2022

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Jan 11, 2022

@tfenne this is why after the updated to 0.8.8 we are seeing spurious CI failures. This is a short term fix.

@nh13 nh13 requested a review from tfenne January 11, 2022 16:13
tfenne
tfenne approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps it should test that it's faster or at least not more than ~5% slower?

@nh13
Copy link
Member Author

nh13 commented Jan 11, 2022

Or perhaps it should test that it's faster or at least not more than ~5% slower?

Why not both!

@nh13 nh13 merged commit 2941e4b into master Jan 11, 2022
@nh13 nh13 deleted the internal/intel-fix branch January 11, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfenne tfenne tfenne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nh13 @tfenne