Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the IterableThreadLocal class and use the one in commons #730

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

kstromhaug
Copy link

No description provided.

@kstromhaug kstromhaug requested a review from nh13 October 19, 2021 22:29
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #730 (77fecce) into master (90d97f2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   95.45%   95.45%   -0.01%     
==========================================
  Files         114      114              
  Lines        6668     6667       -1     
  Branches      448      437      -11     
==========================================
- Hits         6365     6364       -1     
  Misses        303      303              
Flag Coverage Δ
unittests 95.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fulcrumgenomics/umi/ConsensusCallingIterator.scala 100.00% <ø> (ø)
.../scala/com/fulcrumgenomics/bam/api/SamWriter.scala 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d97f2...77fecce. Read the comment docs.

@nh13 nh13 merged commit ef62286 into master Oct 19, 2021
@nh13 nh13 deleted the ks_remove_iterablethreadlocal branch October 19, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants