Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers for mateCigar and matesOverlap on SamRecord #717

Merged
merged 8 commits into from
Sep 28, 2021

Conversation

clintval
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #717 (39fee88) into master (c79a9c9) will increase coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   95.39%   95.42%   +0.03%     
==========================================
  Files         114      114              
  Lines        6596     6623      +27     
  Branches      426      444      +18     
==========================================
+ Hits         6292     6320      +28     
+ Misses        304      303       -1     
Flag Coverage Δ
unittests 95.42% <88.88%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...crumgenomics/rnaseq/EstimateRnaSeqInsertSize.scala 98.29% <50.00%> (-0.02%) ⬇️
.../scala/com/fulcrumgenomics/bam/api/SamRecord.scala 91.91% <100.00%> (+1.21%) ⬆️
.../scala/com/fulcrumgenomics/fastq/DemuxFastqs.scala 96.51% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79a9c9...39fee88. Read the comment docs.

Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change.

@clintval
Copy link
Member Author

Back to you!

@clintval
Copy link
Member Author

Thanks Tim I think that makes a lot of sense!

@clintval clintval changed the title Add helpers for mateCigar and mateOverlaps on SamRecord Add helpers for mateCigar and matesOverlap on SamRecord Sep 27, 2021
@clintval
Copy link
Member Author

Wait to merge, I am redundantly using require twice for all these methods since they delegate back to mateCigar but I can revert that change so we don't have the overhead of checking something twice.

Copy link
Member Author

@clintval clintval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nh13 This is ready for final review!

@clintval
Copy link
Member Author

clintval commented Sep 28, 2021

Ok, done! One more fast path added! I confirmed via coverage reporting all branches are tested too.

@nh13 nh13 merged commit 7a91c97 into fulcrumgenomics:master Sep 28, 2021
@clintval clintval deleted the cv_mate_cigar branch September 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants