Ensure --min-reads is a hard filter in CallDuplexConsensusReads

[clintval]

Closes #1009

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.64%. Comparing base (6ca7733) to head (df69ce8).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
+ Coverage   95.62%   95.64%   +0.01%     
==========================================
  Files         126      126              
  Lines        7388     7395       +7     
  Branches      510      498      -12     
==========================================
+ Hits         7065     7073       +8     
+ Misses        323      322       -1     

Flag	Coverage Δ
unittests	95.64% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[clintval]

We reject the original reads in the group, and not the consensus.

[tfenne]

I took a brief look in VanillaUmiConsensusCaller and it doesn't seem to share this bug, right? I.e. it already re-checks to see if it has enough reads after filtering to the most common alignment.

Feel free to merge after fixing up minor suggestions.

[clintval]

I took a brief look in VanillaUmiConsensusCaller and it doesn't seem to share this bug, right? I.e. it already re-checks to see if it has enough reads after filtering to the most common alignment.

Yes, you are correct!

Documented the reasoning in the original issue too: #1009 (comment)

We should be all set after this PR is merged.