This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
ResourceSet bug when subsetting resources and some performance optimizations #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the minimum to subset to is fractional, with a different fractional value than the maximum, it could be missed. Also added a small performance optimization.
nh13
force-pushed
the
nh_task_manager_speedups_v2
branch
from
df74f6b to
1eee774
Compare
nh13
commented
Mar 23, 2020
nh13
commented
Mar 23, 2020
tfenne
approved these changes
Mar 23, 2020
nh13
added a commit
that referenced
this pull request
Mar 25, 2020
* Pipeline: do not add children of tasks already added * Pipeline: solve stack overflow in addChildren * Task: find cycles in a collection of tasks all at once. When a task returns a list of tasks via getTasks, we currently check for cyclical dependencies on each task independently. If they are all connected in the DAG, then this is really slow! This avoids that by finding the strongly connected components jointly across the new *to be added* tasks. * Small performance optimizations on dense dags * TaskManager: exponential reduction in sleep time if we can do anything, otherwise linear increase * No need to check for cycles before executing a task, as it was checked when added. * Warn if a single step in execution takes longer than 30 seconds * Optimize GraphNode * update based on review * ResourceSet bug when subsetting resources and some performance optimizations (#374) * ResourceSet bug fix If the minimum to subset to is fractional, with a different fractional value than the maximum, it could be missed. * Task Manager optimizations * A few NaiveScheduler simplifications
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.