Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Add the "-K" option from bwa #372

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Add the "-K" option from bwa #372

merged 1 commit into from
Feb 10, 2020

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Feb 10, 2020

No description provided.

@nh13 nh13 requested a review from tfenne February 10, 2020 17:33
Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but with some suggestions for names.

@@ -49,15 +49,16 @@ object Bwa extends Configuration {
mergeBamAlignmentMem: String = "2G",
fifoBufferMem: String = "512M",
processAltMappings: Boolean = false,
orientation: PairOrientation = PairOrientation.FR
orientation: PairOrientation = PairOrientation.FR,
numFixedBases: Option[Int] = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe numInputBases? Or basesPerBatch?

@nh13 nh13 force-pushed the nh_bwa_fixed_num_reads branch from c842b96 to 84eb5d6 Compare February 10, 2020 17:39
@tfenne tfenne assigned nh13 and unassigned tfenne Feb 10, 2020
@nh13 nh13 merged commit ad14fa1 into master Feb 10, 2020
@nh13 nh13 deleted the nh_bwa_fixed_num_reads branch February 10, 2020 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants