Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

PicardTask to allow overriding default use of JDK inflater #367

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

clintval
Copy link
Member

@clintval clintval commented Oct 2, 2019

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #367 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          31       31           
  Lines        1156     1156           
  Branches       65       65           
=======================================
  Hits         1063     1063           
  Misses         93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0bab7...139c152. Read the comment docs.

Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, any reason why you didn't also add USE_JDK_DEFLATER while you were there? For other folks, this is related to the following issues:

@nh13 nh13 merged commit a0a77fb into fulcrumgenomics:master Oct 7, 2019
@clintval
Copy link
Member Author

clintval commented Oct 7, 2019

I think that's what I did? If the Boolean is true, the JDK inflater is used, if the Boolean is false, the Intel inflater (if available) is used. If no Boolean is provided, the Picard default is used.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants