This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to make the GATK tasks a) auto-detect GATK version and b) swi… #365
Attempt to make the GATK tasks a) auto-detect GATK version and b) swi… #365
Changes from all commits
a6815fc
f7b18b9
5c05d24
1bd30ce
6503f2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto about this being something to bake into
JarTask
. We could also have a trait too, since not everything is a JAR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
GenotypeGvcfs
you have a section before this block that adds common arguments:// Args that are common to all versions
I'd recommend moving common args similarly, or not have common args in
GenotypeGvcfs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I almost did it, but in fact there's only 1 common arg, and it felt not worth it. Note that output is
-o
vs.-O
. But I can move the-I
argument out.