This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Add support for empty tasks #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tfenne
approved these changes
Aug 22, 2019
| @@ -128,10 +128,19 @@ class TaskManagerTest extends UnitSpec with OptionValues with LazyLogging with B | |||
| tryTaskNTimes(taskManager = taskManager, task = task, numTimes = 1, taskIsDoneFinally = true, failedAreCompletedFinally = true) | |||
| } | |||
|
|
|||
| it should "run an empty task" in { | |||
There was a problem hiding this comment.
Might be nice to include a test that has a small pipeline of realTask ==> Task.empty ==> anotherRealTask.
|
One other thought would be whether it would make sense to add something like |
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 91.84% 92.03% +0.19%
==========================================
Files 31 31
Lines 1140 1155 +15
Branches 71 66 -5
==========================================
+ Hits 1047 1063 +16
+ Misses 93 92 -1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks.getTaskscan now return an empty list of tasks to run (ex.None,Seq.empty) and the execution system will set the parent task to completed.Tasks$.emptymethod to create a small task whosegetTasksmethod returnsNone.