Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Scatter gather flatMap/groupBy fixup #358

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Scatter gather flatMap/groupBy fixup #358

merged 2 commits into from
Aug 15, 2019

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Aug 13, 2019

One could not follow a flatMap directly by a groupBy.

For example:

Scatter(splitByLane)
  .flatMap { lane => 
    // ex. demultiplexes a flowcell for a given lane, and returns
    // a new [[Scatter]] across libraries for the given lane
    DemultiplexByLane(lane).scatterByLibrary
  } // flatMap returns a sequence of libraries across lanes
  .groupBy { library => (library.sampleName, library.libraryId) } // group across all lanes
  .map { case (_, libraries) => CreateSampleBam(libraries) } // merge library across lanes

@nh13 nh13 requested a review from tfenne August 13, 2019 07:02
@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          31       31           
  Lines        1140     1140           
  Branches       71       71           
=======================================
  Hits         1047     1047           
  Misses         93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b231013...54c1831. Read the comment docs.

@tfenne tfenne assigned nh13 and unassigned tfenne Aug 15, 2019
@nh13 nh13 merged commit fdf8223 into master Aug 15, 2019
@nh13 nh13 deleted the nh_scatter_gather_fixup branch August 15, 2019 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants