Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add a reset method to ReflectiveBuilder #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Apr 21, 2022

This allows ReflectiveBuilder to be re-used to build multiple instances.

This allows ReflectiveBuilder to be re-used to build multiple instances.
@nh13 nh13 requested a review from tfenne April 21, 2022 23:14
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #82 (25bb9f1) into main (9372c55) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   93.46%   93.60%   +0.14%     
==========================================
  Files          28       28              
  Lines         887      891       +4     
  Branches       70       67       -3     
==========================================
+ Hits          829      834       +5     
+ Misses         58       57       -1     
Flag Coverage Δ
unittests 93.60% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...umgenomics/commons/reflect/ReflectiveBuilder.scala 92.42% <100.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9372c55...25bb9f1. Read the comment docs.

nh13 added a commit to fulcrumgenomics/fgbio that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants