Thread local and a test for BiMap #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfenne
approved these changes
Jul 23, 2019
src/main/scala/com/fulcrumgenomics/commons/util/ThreadUtil.scala
Outdated
Show resolved
Hide resolved
| * | ||
| * Care should be taken accessing the iterator since objects may be in use by other threads. | ||
| */ | ||
| def iterator: Iterator[A] = all.toIterator |
There was a problem hiding this comment.
I think toIterator has been deprecated in 2.13. Sorry!
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 93.42% 93.45% +0.03%
==========================================
Files 23 24 +1
Lines 821 825 +4
Branches 72 67 -5
==========================================
+ Hits 767 771 +4
Misses 54 54
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.