Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a specific error when exceeded the rate limit of GitHub API. #273

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

fukamachi
Copy link
Owner

@fukamachi fukamachi commented Sep 3, 2024

ref #264

@fukamachi fukamachi merged commit 6606478 into master Sep 3, 2024
6 checks passed
@fukamachi fukamachi deleted the github-ratelimit-error branch September 3, 2024 13:57
(lambda (e)
(let ((headers (dex:response-headers e)))
(when (nth-value 1 (gethash "x-ratelimit-remaining" headers))
(error 'github-ratelimit-error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably an interactive restart could be provided to retry attempt after a retry-after seconds?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so useful as the default limit is 60 requests per hour so that it can be too long, like 3000 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants