Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease required minimum pub points (tmp fix) #216

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

fujidaiti
Copy link
Owner

@fujidaiti fujidaiti commented Aug 14, 2024

Fixes / Closes (optional)

None.

Description

After the release of Flutter 3.24, pub.dev and pana have started to report the following warning:

40/50 points: code has no errors, warnings, lints, or formatting issues

INFO: 'onPopInvoked' is deprecated and shouldn't be used. Override onPopInvokedWithResult instead. This feature was deprecated after v3.22.0-12.0.pre.

lib/src/modal/modal_sheet.dart:395:13

    ╷
395 │       route.onPopInvoked(didPop);
    │             ^^^^^^^^^^^^

This decreases the package's pub points for the Pass-static-analysis section from 50 to 40, but the current CI requires it to always be 50, resulting in no PR passing the CI.

Although it is possible to fix this warning by following the migration guide, we are not doing this for now as it breaks backward compatibility. Instead, this PR works around this CI issue by decreasing the required pub points for that section to 40 until Flutter 3.24 is widely adopted in the community.

Summary (check all that apply)

  • Modified / added code
  • Modified / added tests
  • Modified / added examples
  • Modified / added others (pubspec.yaml, workflows, etc...)
  • Updated README
  • Contains breaking changes
    • Created / updated migration guide
  • Incremented version number
    • Updated CHANGELOG

@fujidaiti fujidaiti self-assigned this Aug 14, 2024
@fujidaiti fujidaiti marked this pull request as ready for review August 14, 2024 04:03
@fujidaiti fujidaiti merged commit 6f3dd42 into main Aug 14, 2024
5 checks passed
@fujidaiti fujidaiti deleted the decrease-required-pub-points branch August 14, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant