Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when getting attached controller from sub-tree #160

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Conversation

fujidaiti
Copy link
Owner

@fujidaiti fujidaiti commented Jun 5, 2024

Fixed #151.

Manually reverted #102 to remove ImplicitSheetControllerScope which is the cause of #151 and is no longer needed at this time.

@fujidaiti fujidaiti self-assigned this Jun 5, 2024
@fujidaiti fujidaiti changed the title Fix crashes when calling SheetControllerScope.of to get explicitly attached controller Fix a crash when calling SheetControllerScope.of to get explicitly attached controller Jun 5, 2024
@fujidaiti fujidaiti changed the title Fix a crash when calling SheetControllerScope.of to get explicitly attached controller Fix a crash when getting explicitly attached controller from descendant widgets Jun 5, 2024
@fujidaiti fujidaiti changed the title Fix a crash when getting explicitly attached controller from descendant widgets Fix crash when getting attached controller from sub-tree Jun 5, 2024
package/test/navigation/navigation_sheet_test.dart Outdated Show resolved Hide resolved
cookbook/lib/issue/issue151.dart Outdated Show resolved Hide resolved
@fujidaiti fujidaiti merged commit 6b3b455 into main Jun 6, 2024
7 checks passed
@fujidaiti fujidaiti deleted the fix-151 branch June 6, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attaching SheetController to NavigationSheet causes "Null check operator used on a null value"
1 participant