feat: Allow Custom Columns TUI #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
trkelly23
force-pushed
the
Allow-Custom-Columns-tui
branch
from
9d02f00 to
e24bae0
Compare
feat: Allow Custom Columns TUI feat: Allow Custom Columns TUI feat: Allow Custom Columns TUI feat: Allow custom TUI Columns feat: Allow custom TUI Column feat: allow customizing columns rebased (WIP) feat: Allow Custom Columns TUI
trkelly23
force-pushed
the
Allow-Custom-Columns-tui
branch
from
e24bae0 to
c68500a
Compare
|
LGTM ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #757
Added:
Custom columns to TUI interface by either the configuration file or command line option
Calculation of column percentage with 40% constant percentage for hosts column.
Unit tests for TuiColumns and Columns classes
cargo test frontend::columns
cargo test config::columns
Tests run:
cargo run -- -u --tui-custom-columns="" -m tui freebsd.org
cargo run -- -u -c ./trippy-config-sample.toml -m tui freebsd.org
cargo run -- -u --tui-custom-columns="" -c ./trippy-config-sample.toml -m tui freebsd.org
cargo run -- -u --tui-custom-columns="" -m tui freebsd.org
cargo run -- -u --tui-custom-columns="thobwd" -m tui freebsd.org