Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packet size minimum incorrect for IPv6 #985

Closed
fujiapple852 opened this issue Feb 4, 2024 · 0 comments · Fixed by #996
Closed

Packet size minimum incorrect for IPv6 #985

fujiapple852 opened this issue Feb 4, 2024 · 0 comments · Fixed by #996
Labels
bug Something isn't working
Milestone
0.10.0

Comments

@fujiapple852
Copy link
Owner

fujiapple852 commented Feb 4, 2024 •
edited
Loading

The minimum ICMP/UDP packet size for IPv6 is 48 bytes (40 for IPv6 header + 8 for ICMP or UDP header) however the --packet-size command line option has a minimum of 28 bytes, which is correct or IPv4 but crashes for IPv6:

$ ./target/debug/trip -u google.com -6 --packet-size 28 -m stream
Tracing to google.com (2a00:1450:4009:815::200e)
thread 'tracer-19120' panicked at src/tracing/net/ipv6.rs:288:5:
attempt to subtract with overflow

The fix is to ensure the minimum packet size is 48 for IPv6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

fix(config): incorrect minimum packet size for ipv6 (#985) fujiapple852/trippy
1 participant
@fujiapple852