-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for overriding event annotations #90
Conversation
# Conflicts: # framework/src/main/java/org/fulib/fx/controller/ControllerManager.java # framework/src/main/java/org/fulib/fx/controller/internal/ReflectionSidecar.java
…ix/override-annotations
Everything should now work as expected. However, when there is a chain of inheriented classes like While this doesn't affect the process itself, it could be harder to read the error in certain conditions. |
If a method is annotated with an event annotation such as
@OnInit
and is overriding a method from a super class which is also annotated with an event annotation, the method in the class will be called twice due to how java handles overwriting methods.Therefore, overriding an event method shouldn't be allowed and will result in the following error:
Method 'method()' annotated with an event annotation in class 'de.uniks.ludo.controller.SetupController' overrides event method in class 'de.uniks.ludo.controller.BaseController'. [FFX1013]
This PR refactors the processing classes by adding a helper class which doesn't contain framework specific code but methods for streaming different elements
Fixes #86