Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Indev Mode #102

Merged
merged 7 commits into from
May 22, 2024
Merged

Remove Indev Mode #102

merged 7 commits into from
May 22, 2024

Conversation

Clashsoft
Copy link
Member

@Clashsoft Clashsoft commented May 22, 2024

Removals

  • Removed Indev mode.

There were three use cases that can be implemented differently.

  • AutoRefresher: It makes more sense to just check the given path for existence/being a directory, and let the user handle the conditions when the AutoRefresher is started. This avoids the pesky warning.
  • Wrong Routes: There is no reason not to hint about that every time.
    • Maybe we should change the mechanism to put the information in the exception message instead of a log message, in case there is some custom exception handling that would cause the log message to appear out of place.
  • Undisposed Subscribers: I felt this special case a little weird. It makes sense to integrate the Subscriber like this, but it should rather be an annotation processor warning that does not have a runtime cost.

@Clashsoft Clashsoft added the enhancement New feature or request label May 22, 2024
@Clashsoft Clashsoft requested a review from LeStegii May 22, 2024 08:18
@Clashsoft Clashsoft self-assigned this May 22, 2024
@LeStegii LeStegii changed the title Remove Index Mode Remove Indev Mode May 22, 2024
Copy link
Collaborator

@LeStegii LeStegii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but as you said yourself already, extending the error message would be better than having a seperate log output.

@Clashsoft Clashsoft merged commit dfc427c into master May 22, 2024
4 checks passed
@Clashsoft Clashsoft deleted the remove/indev branch May 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants