Fix and extend KSY schema #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added support for doc and doc-ref properties in many places * Added support for params on types * Added various meta properties * Added support for verbose enums * Added support for endian switching * Added pad-right property * Added -orig-id property * Allowed arbitrary properties starting with a dash in various places * Allowed meta sections on non-top-level types * Allowed string values for terminator property (needed for non-decimal number literals) * Allowed using booleans in place of strings in a few places * Changed encoding property from an enum to a plain string - it's impossible to list all available encodings (especially since they vary between target languages) * Removed incorrect patterns from switch-on and enum keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies half of everything in the schema - see the commit message for a list of what exactly I added/fixed. But now the schema works with every spec in kaitai_struct_formats (plus a few of my specs that I haven't published yet).