Skip to content

Commit

Permalink
Remove redundant override in Iceberg
Browse files Browse the repository at this point in the history
  • Loading branch information
ebyhr authored and findepi committed Aug 2, 2022
1 parent 080216f commit da44a6d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,19 +146,13 @@ protected BaseIcebergConnectorTest(IcebergFileFormat format)
this.format = requireNonNull(format, "format is null");
}

protected Map<String, String> additionalIcebergProperties()
{
return ImmutableMap.of();
}

@Override
protected QueryRunner createQueryRunner()
throws Exception
{
return IcebergQueryRunner.builder()
.setIcebergProperties(ImmutableMap.<String, String>builder()
.put("iceberg.file-format", format.name())
.putAll(additionalIcebergProperties())
.buildOrThrow())
.setInitialTables(ImmutableList.<TpchTable<?>>builder()
.addAll(REQUIRED_TPCH_TABLES)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,9 @@
*/
package io.trino.plugin.iceberg;

import com.google.common.collect.ImmutableMap;
import io.trino.Session;
import org.testng.SkipException;

import java.util.Map;

import static io.trino.plugin.iceberg.IcebergFileFormat.AVRO;

public class TestIcebergAvroConnectorTest
Expand All @@ -29,13 +26,6 @@ public TestIcebergAvroConnectorTest()
super(AVRO);
}

@Override
protected Map<String, String> additionalIcebergProperties()
{
// Iceberg AVRO doesn't support ZSTD (connector's default) compression codec
return ImmutableMap.of("iceberg.compression-codec", "SNAPPY");
}

@Override
protected boolean supportsIcebergFileStatistics(String typeName)
{
Expand Down

0 comments on commit da44a6d

Please sign in to comment.