Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore \item, even if there is an unsafe command after the item #89

Merged
merged 1 commit into from
Mar 10, 2017

Conversation

jprotze
Copy link
Contributor

@jprotze jprotze commented Mar 9, 2017

Handling items breaks if the \item is followed by a command. For removing this code:

\begin{itemize}
\item \verb{my_id_t} for reference see \myref{sec:my_id_t}.
\end{itemize}

The result was:

%DIFDELCMD < \begin{itemize}
\begin{itemize}%DIFAUXCMD
%DIFDELCMD < \item \verb{my_id_t} %%%
\DIFdel{type, see
}%DIFDELCMD < \myref{sec:my_id_t}%%%
\DIFdel{.
}
\end{itemize}%DIFAUXCMD
%DIFDELCMD < \end{itemize}

Probably, this is not only a problem for commands? Should we check for more than just $cmdoptseq?

@ftilmann ftilmann merged commit 0577ed7 into ftilmann:master Mar 10, 2017
ftilmann added a commit that referenced this pull request Mar 10, 2017
@ftilmann
Copy link
Owner

Thanks for pointing this out. I have merged after modifying it to your comment that one ought to check for several unsafe commands - also I retain the %DIFDELCMD < \item ... command, which then makes it redundant to include the commented out unsafe commands explicitly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants