Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import package support (\import and \subimport commands) #173

Merged
merged 2 commits into from
Jun 16, 2019

Conversation

jasonmccsmith
Copy link

Fix for issue #172.

Extends flatten to take directory argument, allowing \subimport to incrementally add to the search path, or \import to replace it.

Updated doc strings to reflect additional capability.

@ftilmann ftilmann merged commit 9c9d747 into ftilmann:master Jun 16, 2019
@ftilmann
Copy link
Owner

ftilmann commented Jun 16, 2019

I have merged this commit but note that I have not truly tested it, I only verified it does not break any of the existing test cases. I would be great if you could contribute a simple test case to the testsuite directory, or simply give me access to old and new files, and imported files, and I can set up the test case trivially (it does not even need to be an MWE, but obviously should contain no information you would not want to see on github, and should run without any custom packages or require other files not contributed. This is also the only way to ensure that future updates do not break the import flattening inadvertently.

A minor thing I had to fix was that the File::Spec->rel2abs option is now used in the main code (in argument to flatten call), which means this package has to be now loaded by default (previously only loaded within the flatten subroutine). I assume the use of rel2abs in the flatten argument is necessary, so I added a use File::Spec to the beginning.

@jasonmccsmith jasonmccsmith deleted the issue172 branch June 20, 2019 13:18
@jasonmccsmith jasonmccsmith restored the issue172 branch June 20, 2019 18:48
@jasonmccsmith
Copy link
Author

jasonmccsmith commented Jun 22, 2019 via email

@ftilmann
Copy link
Owner

Thanks. However, I don't see the attachments. Maybe I don't know where to look or the github system stripped them. If you wish you can also send them by direct email. My email address is in the latexdiff man page under BUGS.

@jasonmccsmith
Copy link
Author

Attachment was stripped out by github on posting from email response, now attached above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants