Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hg option not working #93

Closed
kandolfp opened this issue Apr 3, 2017 · 7 comments
Closed

hg option not working #93

kandolfp opened this issue Apr 3, 2017 · 7 comments

Comments

@kandolfp
Copy link

kandolfp commented Apr 3, 2017

The --hg option is ignored in latexdiff-vc. I used a workaround by inserting $vc="HG"; on line 148 but there is definitely a better way.
With this fix I also get the error message can't find file to patch at input line 4 that is solved by retyping the file name when prompted to.
I'm running:

  • Mercurial Distributed SCM (version 4.1.1) with BitBucket
  • LATEXDIFF-VC 1.1.1 but the bug is also in the current version
@ftilmann
Copy link
Owner

ftilmann commented Apr 3, 2017

The first problem was a silly omission, which should now be fixed. The second issue looks slightly more complicated. I have to confess to be almost completely unfamiliar with hg - this functionality was contributed by @junghans back in 2015, and it seemed to work for him but I never actually tested it myself. The only way to realistically reproduce your bug report and eventually fix the problem would be if you could prepare a tar package of the directory where this error occurs (ideally reduced to an MWE) including the hidden .hg subdirectory, and the exact sequence of commands that produces the error.

@kandolfp
Copy link
Author

kandolfp commented Apr 3, 2017 via email

@junghans
Copy link
Contributor

junghans commented Apr 3, 2017

Hmm, I guess I never tried using -r without a revision, e.g.

latexdiff-vs -r myfile.tex

Maybe we should a test case along the lines:

for vs in git hg; do
  type -p $vs || continue
  $vs init xxx
  cd xxx
  $vs add somefile.tex
  $vs commit -m "initial commit"
  sed -i 's/text/text text/' somefile.tex
  latexdiff-vs -r somefile.tex
done

junghans added a commit to junghans/latexdiff that referenced this issue Apr 3, 2017
junghans added a commit to junghans/latexdiff that referenced this issue Apr 3, 2017
junghans added a commit to junghans/latexdiff that referenced this issue Apr 4, 2017
@kandolfp
Copy link
Author

kandolfp commented Apr 4, 2017 via email

@junghans
Copy link
Contributor

junghans commented Apr 4, 2017

@kandolfp: Try #94, it should fix the remaining two issues.

@kandolfp
Copy link
Author

kandolfp commented Apr 4, 2017 via email

ftilmann added a commit that referenced this issue Apr 4, 2017
@ftilmann
Copy link
Owner

ftilmann commented Apr 4, 2017

@junghans thanks for this patch; I am glad this could be fixed so quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants