Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

description,list,enumerate environment: deleted \item #1

Closed
ftilmann opened this issue Jun 17, 2014 · 1 comment
Closed

description,list,enumerate environment: deleted \item #1

ftilmann opened this issue Jun 17, 2014 · 1 comment
Labels

Comments

@ftilmann
Copy link
Owner

If the first item is deleted from a list environment then the description environment begins with normal text (as deleted \item commented out), which is not allowed.

Related feature request: it would be nice if the deleted items could be actually shown as such, in particular for description environments

@ftilmann
Copy link
Owner Author

Fixed with commit 6992d3e

michaelmhoffman added a commit to michaelmhoffman/latexdiff that referenced this issue Feb 23, 2023
This hack just changes in the DATA section:

ulem -> lua-ul
[normalem] ->
\sout -> \strikeThrough
\uwave -> \underLine

When this is used, output must be compiled with lualatex.

Some thoughts on implementing this in upstream latexdiff:

1. To make this an actual option, instead of hardcoding this change,
one would probably want to make general commands that call the right
ulem or lua-ul commnad, with separate preamble sections for either
ulem:

\RequirePackage[normalem]{ulem}
\newcommand[1]{\DIFstrikethrough}{\sout{ftilmann#1}}
\newcommand[1]{\DIFunderline}{\uwave{ftilmann#1}}

or lua-ul

\RequirePackage{lua-ul}
\newcommand[1]{\DIFstrikethrough}{\strikeThrough{ftilmann#1}}
\newcommand[1]{\DIFunderline}{\underLine{ftilmann#1}}

and then could make these changes instead

\RequirePackage[normalem]{ulem} ->
\sout -> \DIFstrikethrough
\uwave -> \underLine

This, however, would require adding in the logic to have either lua-ul or ulem into
the code.

I also hope the indirection like this won't break some LaTeX macro
somewhere but can't be sure of that.

Other options I considered would be:
- duplicating all these sections to have a ulem and a lua-ul
version (yuck)
- searching for these words and replacing them when reading in
preamble sections (D:)
- simply eliminating ulem support (working around it certainly seems to have caused a
lot of headaches for the creators of latexdiff)

2. lua-ul doesn't have the capacity out of the box to produce wavy
underlines like ulem, but is very configurable and it could be added.
Instructions are even in the lua-ul manual.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant