Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add take method to NonEmptyList and NonEmptyVector #854

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Add take method to NonEmptyList and NonEmptyVector #854

merged 2 commits into from
Oct 12, 2020

Conversation

zaneli
Copy link
Contributor

@zaneli zaneli commented Oct 12, 2020

I want to add take method to NonEmptyList and NonEmptyVector for convenience.

fthomas
fthomas approved these changes Oct 12, 2020
View reviewed changes
Copy link
Owner

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks, @zaneli! I added one comment about the performance of take for NonEmptyList.

modules/cats/shared/src/main/scala/eu/timepit/refined/cats/syntax.scala Outdated Show resolved Hide resolved
@zaneli @fthomas
Optimize take for NonEmptyList
7237ed4 
Co-authored-by: Frank S. Thomas <[email protected]>
@zaneli zaneli requested a review from fthomas October 12, 2020 14:36
@fthomas fthomas merged commit 0b01791 into fthomas:master Oct 12, 2020
@zaneli zaneli deleted the non-empty-take branch October 12, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fthomas fthomas Awaiting requested review from fthomas

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaneli @fthomas