Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Int and Double literals as universal arguments #841

Merged
merged 9 commits into from
Sep 26, 2020

Conversation

fthomas
Copy link
Owner

@fthomas fthomas commented Sep 25, 2020

... for numeric predicates. See #763 for discussion.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #841 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #841   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files          48       48           
  Lines         529      529           
  Branches       10       12    +2     
=======================================
  Hits          484      484           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e1955...61ba27f. Read the comment docs.

@fthomas
Copy link
Owner Author

fthomas commented Sep 26, 2020

This change allows us to use the Int literal 0 instead of shapeless._0 in the definition of Positive and similar predicates. This will be done in the 0.10 release.

@erikerlandson
Copy link
Contributor

This is cool 🎉

@fthomas fthomas merged commit 21aa99a into master Sep 26, 2020
@fthomas fthomas deleted the topic/int-double-as-universal-args branch September 26, 2020 21:20
fthomas added a commit that referenced this pull request Sep 27, 2020
* Use Int literals for numeric predicates like Positive

See #841 (comment).

* Replace Nat in MaxSize and NonEmptyFiniteString
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Literal predicates for BigDecimal
2 participants