upgrade scalaz and use latest features #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fommil
commented
Apr 6, 2018
| override implicit val G: MonadError[MT, String] = ME | ||
| override val iso: Decoder <~> MT = isoReaderT | ||
| } | ||
| MonadError.fromIso(isoReaderT) |
There was a problem hiding this comment.
.fromIso was added specifically to help with this usecase.
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
- Coverage 98.2% 98.05% -0.15%
==========================================
Files 58 60 +2
Lines 667 670 +3
Branches 11 11
==========================================
+ Hits 655 657 +2
- Misses 12 13 +1
Continue to review full report at Codecov.
|
|
it looks to me like codecov doesn't know how to count 😼 |
|
LGTM, thanks @fommil! |
|
FYI @fthomas we're investigating how to make the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.