Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent glob behaviour for "**" patterns #143

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Consistent glob behaviour for "**" patterns #143

merged 3 commits into from
Sep 20, 2023

Conversation

ap--
Copy link
Collaborator

@ap-- ap-- commented Sep 4, 2023

With fsspec>=2023.9.0 UPath.glob() behaviour for patterns containing "**" has been fixed.

This PR fixes UPath.rglob when an fsspec version is installed with a correct implementation of glob.

Closes #80

normanrz
normanrz reviewed Sep 5, 2023
View reviewed changes
@ap-- ap-- closed this Sep 17, 2023
@ap-- ap-- reopened this Sep 17, 2023
@ap-- ap-- merged commit 0102132 into fsspec:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Glob on s3 bucket should be coherent with other implementations?
2 participants
@ap-- @normanrz