Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more HDF4 #509

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fix more HDF4 #509

merged 3 commits into from
Sep 27, 2024

Conversation

martindurant
Copy link
Member

  • NDG groups
  • null terminated strings

Fixes #505 , cc @abarciauskas-bgse

- NDG groups
- null terminated strings
@martindurant
Copy link
Member Author

This of course reinforces that we will really need some HDF4 tests; but it's less clear what the "ground truth" should be!

@abarciauskas-bgse
Copy link
Contributor

Thank you @martindurant ! I tried this with MCD12Q1 (after pip install git+https://github.com/martindurant/fsspec-reference-maker.git@hdf4_2) it is working! 🙏🏽

@martindurant martindurant merged commit 09d7a92 into fsspec:main Sep 27, 2024
5 checks passed
@martindurant martindurant deleted the hdf4_2 branch September 27, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for MOD14A1 MODIS/Terra Thermal Anomalies/Fire Daily L3 Global 1km SIN Grid V061
2 participants