Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for lat/lon 1D array in grib2 #239

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Fix for lat/lon 1D array in grib2 #239

merged 2 commits into from
Oct 24, 2022

Conversation

martindurant
Copy link
Member

@martindurant martindurant commented Oct 19, 2022 •
edited
Loading

Fixes #238

@martindurant
Copy link
Member Author

Needs a test

@lucien-sim
Copy link

I've tested this with the GEFS files, it does the job.

@martindurant
Copy link
Member Author

OK, merging this, but finding a suitable test is still TODO. I don't know if we can persuade xarray to write a grib2 file of this sort.

@martindurant martindurant merged commit 54165a5 into fsspec:main Oct 24, 2022
@martindurant martindurant deleted the grib_1d_coords branch October 24, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem using scan_grib with GEFS output
2 participants
@martindurant @lucien-sim