Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for single json dict environment variable for protocol #1194

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Add support for single json dict environment variable for protocol #1194

merged 3 commits into from
Feb 28, 2023

Conversation

mauvilsa
Copy link
Contributor

Implements #1130.

@mauvilsa mauvilsa mentioned this pull request Feb 23, 2023
Open
@martindurant
Copy link
Member

Thanks for working on this!
Will look at this early next week - please ping if you don't hear anything.

@martindurant martindurant mentioned this pull request Feb 26, 2023
Closed
timsnyder
timsnyder reviewed Feb 26, 2023
View reviewed changes
Copy link
Contributor

@timsnyder timsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some logging of the silently dropped cases might be helpful. I know it would help me as a user.

fsspec/config.py Outdated Show resolved Hide resolved
fsspec/config.py Show resolved Hide resolved
timsnyder
timsnyder reviewed Feb 26, 2023
View reviewed changes
docs/source/features.rst Outdated Show resolved Hide resolved
@mauvilsa mauvilsa requested review from martindurant and timsnyder and removed request for martindurant and timsnyder February 28, 2023 12:41
@martindurant
Copy link
Member

Thank you!

@martindurant martindurant merged commit 5ac661e into fsspec:master Feb 28, 2023
@mauvilsa mauvilsa deleted the single-env-proto branch February 28, 2023 14:32
agoodm pushed a commit to agoodm/filesystem_spec that referenced this pull request Mar 14, 2023
@mauvilsa @timsnyder @agoodm
Add support for single json dict environment variable for protocol (f…
57314ab 
…sspec#1194)

* Add support for single json dict environment variable for protocol.

* Update docs/source/features.rst

Co-authored-by: Tim Snyder <[email protected]>

* Add warnings when environment variables are ignored.

---------

Co-authored-by: Tim Snyder <[email protected]>
This was referenced Mar 30, 2023
Closed
Merged
@JoostvDoorn JoostvDoorn mentioned this pull request Jul 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsnyder timsnyder timsnyder left review comments

@martindurant martindurant Awaiting requested review from martindurant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauvilsa @martindurant @timsnyder