spec: get_file: don't pollute with files and fds #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if anything happens in fs.open we will leave an empty file in user's workspace and also won't close the file descriptor. Both things are pretty bad.
efiop
commented
Feb 20, 2023
Comment on lines
849
to
+853
| if isfilelike(lpath): | ||
| outfile = lpath | ||
| else: | ||
| if self.isdir(rpath): | ||
| os.makedirs(lpath, exist_ok=True) | ||
| return None | ||
| elif self.isdir(rpath): | ||
| os.makedirs(lpath, exist_ok=True) | ||
| return None |
There was a problem hiding this comment.
These don't seem mutually exclusive, but I've preserved logic that was here before. Not sure what outfile argument is even used for, but it is strange that makedirs-behaviour (which is also odd by itself) doesn't affect it.
EDIT: nevermind, indeed they are mutually exclusive.
There was a problem hiding this comment.
Also calling isdir on every file is very wasteful. Ideally, we should get rid of this at some point in the future, as it seems to be a misplaced piece of logic from fs.get rather than something that is intentional here. From user's perspective I would expect IsADirectoryError here.
This was referenced Feb 20, 2023
efiop
added a commit
to iterative/scmrepo
that referenced
this pull request
Feb 20, 2023
While waiting for fsspec/filesystem_spec#1191
efiop
added a commit
to iterative/scmrepo
that referenced
this pull request
Feb 20, 2023
While waiting for fsspec/filesystem_spec#1191
efiop
added a commit
to iterative/scmrepo
that referenced
this pull request
Feb 20, 2023
While waiting for fsspec/filesystem_spec#1191
agoodm
pushed a commit
to agoodm/filesystem_spec
that referenced
this pull request
Mar 14, 2023
* spec: get_file: don't pollute with files and fds Currently if anything happens in fs.open we will leave an empty file in user's workspace and also won't close the file descriptor. Both things are pretty bad. * http: _get_file: don't leak file descriptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if anything happens in fs.open we will leave an empty file in user's workspace and also won't close the file descriptor. Both things are pretty bad.