Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support InitialSubscritionName for DLQ #249

Closed
adrianotr opened this issue Feb 7, 2024 · 5 comments
Closed

Support InitialSubscritionName for DLQ #249

adrianotr opened this issue Feb 7, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@adrianotr
Copy link
Contributor

Hello!

Currently the pulsar-client-dotnet api does not expose a way to create a initial subscription for dead-letter topics.
However, topics without any subscriptions do not retain messages.
Pulsar supports this already, and it seems we already have the parameter mapped in the Protobuf.

Can we add the InitialSubscriptionName attribute to the DeadLetterPolicy and send that to Pulsar during the Consumer subscription using the existing Protobuf attribute?

@adrianotr
Copy link
Contributor Author

I've created this PR just to give you an idea of the changes needed.

@Lanayx
Copy link
Member

Lanayx commented Feb 8, 2024

Hi, @adrianotr ! Thank you for the contribution, you can continue working on PR and I'll merge it once ready. Please, don't forget to add integration test for this new feature as well.

@Lanayx Lanayx added developer needed enhancement New feature or request and removed developer needed labels May 18, 2024
@adrianotr
Copy link
Contributor Author

Hi! I've pushed a new PR with an integration test: #273

@Lanayx
Copy link
Member

Lanayx commented Aug 8, 2024

Published https://www.nuget.org/packages/Pulsar.Client/3.6.0, can you please verify?

@adrianotr
Copy link
Contributor Author

Hi @Lanayx! I've tested the new feature and it works as expected. Thanks for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants