Fix for issue 452 #455
Merged
Fix for issue 452 #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, meaning lack of parentheses no longer causes fantomas to generate invalid code
Smaug123
reviewed
Aug 1, 2019
| let ``attributes without parentheses on expressions``() = | ||
| formatSourceString false """ | ||
| [<MyValue 55>] | ||
| do ()""" config |
There was a problem hiding this comment.
Could you add a test for what happens if there are too many spaces in the attribute? (presumably they get stripped down to 1)
There was a problem hiding this comment.
Yes, will also add similar tests for args in parens
|
Thanks for your contribution! ❤️ Nowadays all new changes are done in |
|
Is this ready? |
nojaf
requested changes
Aug 13, 2019
nojaf
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no spacing applied between the attribute type name and its arguments. This is probably because it was assumed that they'd always be between parentheses. Now Fantomas will check to see if the arg expression for attributes is between parentheses. If it isn't then it will add a space to ensure the code generated still compiles.