POC double indentation. #3039
Draft
POC double indentation. #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@auduchinok I'd be interested to hear more about what this change lets you do. |
nojaf
force-pushed
the
poc/double-indent
branch
from
e10b3a7 to
c4f0774
Compare
nojaf
commented
Feb 10, 2024
| equal | ||
| """ | ||
| type X() = | ||
| member x.Y |
There was a problem hiding this comment.
@auduchinok this does the double indent but has the multiline tuple parameter.
According to the existing lore, we indent each entry of the tuple.
Does this meet your expectations?
|
I talked a bit more with @auduchinok on this. It could be interesting to follow the approach of putting parameters on the current line until the max line length is crossed:
It keeps things compact and having the double indent helps to differentiate the parameters with the body. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick implementation of having double indentation for long function signature parameters.
//cc @auduchinok @dawedawe @josh-degraw @Smaug123
Note that the equals sign rule didn't change. The guide is pretty clear on that. It goes on its own line.
Unless the last parameter is a long tuple.
For the sake of source control, I wouldn't change that: