Upgrade to FSharp.Compiler.Service 39. #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nojaf, would this merge be functionally identical with 4.4.0? I'm asking because I'd like to ship both 4.5 and 4.4 with FCS 39. |
|
Hey Asti, yes it would be. I released 4.4 and then the first thing I did was this PR to have support for FCS 39. |
|
Thanks! Really wanted to push out 4.5 alpha with FCS 39.Gotta go fix my other projects. I look forward to and dread FCS updates at the same time. 🙃
|
knocte
pushed a commit
to nblockchain/fantomless
that referenced
this pull request
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes #1343 as the do keyword is included in the range of SynExpr.Do again.
//cc @auduchinok