Print trivia of SynMatchClause #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nojaf CI on 1st commit was broken because Humberto forgot to run fantomas on fantomas itself, but 2nd commit should have passed, however, the failure seems unrelated to this PR (something about paket...?). |
nojaf
requested changes
Jan 12, 2021
There was a problem hiding this comment.
Hello @HumbertoCortes, thank you for this contribution.
Unfortunately, I'd like to see a different implementation.
Please let me know if you need further assistance.
nojaf
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Hey @HumbertoCortes, looks good.
Thanks for the requested changes.
I've tweaked some stuff here and there to work with the full range of SynMatchClause.
Related dotnet/fsharp#10877
|
Fixes #1219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments inside
withblock (of a try-with) are formatted. In the Clauses generation method ("genClause") a genTrivia call ("genTriviaMainNodesBeforeClausePipe") is inserted in the CodePrinter. The new method look for a trivia nodes with in TriviaMainNodes list.Two unit test are added to test the correct behaviour.