-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Something like MultilineBlockBracketsOnSameColumn but for parentheses #815
Labels
Comments
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Nov 6, 2020
This version of fantomas doesn't crash anymore when formatting it: dotnet tool install -g fantomas-tool --add-source https://www.myget.org/F/fantomas/api/v3/index.json --framework netcoreapp3.1 --version 4.0.0-alpha-012 Source will be formatted using this command: fantomas --recurse src/GWallet.Backend/ Things that would need to be fixed manually before merging this to master: - We can drop parens in many if statements, e.g.: StratumClient.fs' CreateVersion's, ServerManager.fs' GetDummyBalanceAction, FTPC.fs' FTPC type, EtherAccount.fs' GetTransactionCount - Drop parents in ReadAllText calls of Account.fs - Many raise lines should use <|, e.g. in WarpKey.fs, UtxoCoinAccount.fs, and ElectrumServer.fs - UtxoCoinAccount.fs' EstimateFees unneeded use of |> with 'head' Fantomas issues from geewallet's wishlist: - fsprojects/fantomas#712 - fsprojects/fantomas#684 - fsprojects/fantomas#964 - fsprojects/fantomas#1218 - fsprojects/fantomas#815 or fsprojects/fantomas#1221 (but 815 preferred) Issues not yet reported: - There should be a setting called AlwaysSplitPipeOperatorInNewLine? but I actually don't understand the consistency of this: ``` use webClient = new WebClient() let serverListInJson = webClient.DownloadString urlToElectrumJsonFile ExtractServerListFromElectrumJsonFile serverListInJson - |> Seq.filter FilterCompatibleServer + |> Seq.filter FilterCompatibleServer - let DefaultBtcList = - Caching.Instance.GetServers Currency.BTC - |> List.ofSeq + let DefaultBtcList = Caching.Instance.GetServers Currency.BTC |> List.ofSeq ``` - MaxLineLength not being respected? look at how long some lines in UtxoCoinAccount.fs' GetAccountFromFile are. - UtxoCoinAccount.fs' TransactionOutpoint.ToCoin() should start on next line. - Why cut `truncated` var assignment in Formatting.fs' DecimalAmountTruncating func? - FaultTolerantParallelClient.fs' Runner.Run is tooooooo long - Moving comment of FTPC.fs' CustomCancelSource's Dispose func - This stupid diff adding an unneeded space: ``` return! faultTolerantEtherClient.Query (FaultTolerantParallelClientDefaultSettings ServerSelectionMode.Fast - currency - (Some (AverageBetweenResponses (minResponsesRequired, AverageGasPrice)))) + currency + (Some (AverageBetweenResponses (minResponsesRequired, AverageGasPrice)))) web3Funcs ``` - (Investigate) FSharpUtil.option{} that contains a `do! if...`, WAT - In a lock() statement, it should allow placing the ending `)` in its own line at the end, in the same column where `lock` starts. Last but not least, investigate if alpha-012 contains unwanted things like 311bff817f89f8b47c0799eb7474da886175ef15, otherwise we might need to go back to 04c48d5, which should be alpha-011 with these fantomas-config.json settings: { "IndentSpaceNum":4, "PageWidth":80, "SemicolonAtEndOfLine":false, "SpaceBeforeParameter":true, "SpaceBeforeLowercaseInvocation":true, "SpaceBeforeUppercaseInvocation":true, "SpaceBeforeClassConstructor":true, "SpaceBeforeMember":true, "SpaceBeforeColon":false, "SpaceAfterComma":true, "SpaceBeforeSemicolon":false, "SpaceAfterSemicolon":true, "IndentOnTryWith":true, "SpaceAroundDelimiter":true, "MaxIfThenElseShortWidth":0, "MaxInfixOperatorExpression":80, "MaxRecordWidth":0, "MaxFunctionBindingWidth":0, "MaxValueBindingWidth":80, "MultilineBlockBracketsOnSameColumn":true, "NewlineBetweenTypeDefinitionAndMembers":true, "KeepIfThenInSameLine":true, "StrictMode":false }
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Nov 10, 2020
This version of fantomas doesn't crash anymore when formatting it: dotnet tool install -g fantomas-tool --add-source https://www.myget.org/F/fantomas/api/v3/index.json --framework netcoreapp3.1 --version 4.0.0-alpha-012 Source will be formatted using this command: fantomas --recurse src/GWallet.Backend/ Things that would need to be fixed manually before merging this to master: - We can drop parens in many if statements, e.g.: StratumClient.fs' CreateVersion's, ServerManager.fs' GetDummyBalanceAction, FTPC.fs' FTPC type, EtherAccount.fs' GetTransactionCount - Drop parents in ReadAllText calls of Account.fs - Many raise lines should use <|, e.g. in WarpKey.fs, UtxoCoinAccount.fs, and ElectrumServer.fs - UtxoCoinAccount.fs' EstimateFees unneeded use of |> with 'head' Fantomas issues from geewallet's wishlist: - fsprojects/fantomas#712 - fsprojects/fantomas#684 - fsprojects/fantomas#964 - fsprojects/fantomas#1218 - In a lock() statement, it should allow placing the ending `)` in its own line at the end, in the same column where `lock` starts: fsprojects/fantomas#815 or fsprojects/fantomas#1221 (but 815 preferred) - FaultTolerantParallelClient.fs' Runner.Run is tooooooo long: fsprojects/fantomas#1133 - Moving comment of FTPC.fs' CustomCancelSource's Dispose func: fsprojects/fantomas#1233 Issues not yet reported: - There should be a setting called AlwaysSplitPipeOperatorToNewLine? - MaxLineLength not being respected? look at how long some lines in UtxoCoinAccount.fs' GetAccountFromFile are. - UtxoCoinAccount.fs' TransactionOutpoint.ToCoin() should start on next line. - This stupid diff adding an unneeded space: ``` return! faultTolerantEtherClient.Query (FaultTolerantParallelClientDefaultSettings ServerSelectionMode.Fast - currency - (Some (AverageBetweenResponses (minResponsesRequired, AverageGasPrice)))) + currency + (Some (AverageBetweenResponses (minResponsesRequired, AverageGasPrice)))) web3Funcs ``` - (Investigate) FSharpUtil.option{} that contains a `do! if...`, WAT Last but not least, investigate if alpha-012 contains unwanted things like 311bff817f89f8b47c0799eb7474da886175ef15, otherwise we might need to go back to 04c48d5, which should be alpha-011 with these fantomas-config.json settings: { "IndentSpaceNum":4, "PageWidth":80, "SemicolonAtEndOfLine":false, "SpaceBeforeParameter":true, "SpaceBeforeLowercaseInvocation":true, "SpaceBeforeUppercaseInvocation":true, "SpaceBeforeClassConstructor":true, "SpaceBeforeMember":true, "SpaceBeforeColon":false, "SpaceAfterComma":true, "SpaceBeforeSemicolon":false, "SpaceAfterSemicolon":true, "IndentOnTryWith":true, "SpaceAroundDelimiter":true, "MaxIfThenElseShortWidth":0, "MaxInfixOperatorExpression":80, "MaxRecordWidth":0, "MaxFunctionBindingWidth":0, "MaxValueBindingWidth":80, "MultilineBlockBracketsOnSameColumn":true, "NewlineBetweenTypeDefinitionAndMembers":true, "KeepIfThenInSameLine":true, "StrictMode":false }
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Nov 10, 2020
This version of fantomas doesn't crash anymore when formatting it: dotnet tool install -g fantomas-tool --add-source https://www.myget.org/F/fantomas/api/v3/index.json --framework netcoreapp3.1 --version 4.0.0-alpha-012 Source will be formatted using this command: fantomas --recurse src/GWallet.Backend/ Things that would need to be fixed manually before merging this to master: - We can drop parens in many if statements, e.g.: StratumClient.fs' CreateVersion's, ServerManager.fs' GetDummyBalanceAction, FTPC.fs' FTPC type, EtherAccount.fs' GetTransactionCount - Drop parents in ReadAllText calls of Account.fs - Many raise lines should use <|, e.g. in WarpKey.fs, UtxoCoinAccount.fs, and ElectrumServer.fs - UtxoCoinAccount.fs' EstimateFees unneeded use of |> with 'head' Fantomas issues from geewallet's wishlist: - fsprojects/fantomas#712 - fsprojects/fantomas#684 - fsprojects/fantomas#964 - fsprojects/fantomas#1235 - fsprojects/fantomas#1218 - In a lock() statement, it should allow placing the ending `)` in its own line at the end, in the same column where `lock` starts: fsprojects/fantomas#815 or fsprojects/fantomas#1221 (but 815 preferred) - FaultTolerantParallelClient.fs' Runner.Run is tooooooo long: fsprojects/fantomas#1133 - Moving comment of FTPC.fs' CustomCancelSource's Dispose func: fsprojects/fantomas#1233 Issues not yet reported: - There should be a setting called AlwaysSplitPipeOperatorToNewLine? - MaxLineLength not being respected? look at how long some lines in UtxoCoinAccount.fs' GetAccountFromFile are. - UtxoCoinAccount.fs' TransactionOutpoint.ToCoin() should start on next line -> fixed in v.NEXT - This stupid diff adding an unneeded space: ``` return! faultTolerantEtherClient.Query (FaultTolerantParallelClientDefaultSettings ServerSelectionMode.Fast - currency - (Some (AverageBetweenResponses (minResponsesRequired, AverageGasPrice)))) + currency + (Some (AverageBetweenResponses (minResponsesRequired, AverageGasPrice)))) web3Funcs ``` (seems to be fixed in v.NEXT) - (Investigate) FSharpUtil.option{} that contains a `do! if...`, WAT Last but not least, investigate if alpha-012 contains unwanted things like 311bff817f89f8b47c0799eb7474da886175ef15, otherwise we might need to go back to 04c48d5, which should be alpha-011 with these fantomas-config.json settings: { "IndentSpaceNum":4, "PageWidth":80, "SemicolonAtEndOfLine":false, "SpaceBeforeParameter":true, "SpaceBeforeLowercaseInvocation":true, "SpaceBeforeUppercaseInvocation":true, "SpaceBeforeClassConstructor":true, "SpaceBeforeMember":true, "SpaceBeforeColon":false, "SpaceAfterComma":true, "SpaceBeforeSemicolon":false, "SpaceAfterSemicolon":true, "IndentOnTryWith":true, "SpaceAroundDelimiter":true, "MaxIfThenElseShortWidth":0, "MaxInfixOperatorExpression":80, "MaxRecordWidth":0, "MaxFunctionBindingWidth":0, "MaxValueBindingWidth":80, "MultilineBlockBracketsOnSameColumn":true, "NewlineBetweenTypeDefinitionAndMembers":true, "KeepIfThenInSameLine":true, "StrictMode":false }
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Feb 22, 2021
Command to install: dotnet tool install --global fantomas-tool --version 4.4.0-beta-008 Command to run: fantomas --recurse src/GWallet.Backend/ Fantomas bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one maybe doesn't affect us anymore) TODO: finish this list above from the commit messages in experiments/fantomas branch
I'm going to close this as it falls under What are we not looking for?. |
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Sep 27, 2021
Command to install: dotnet tool install --global fantomas-tool --version 4.5.3 Command to run: fantomas --recurse src/GWallet.Backend/ Fantomas bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1901 * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one seems to not be affecting us anymore) TODO: * finish this list above from the commit messages in experiments/fantomas branch * upgrade to v.NEXT (after 4.5.3, so 4.5.4?) to see if our vanity alignment has been fixed in our exceptions
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Sep 27, 2021
Command to install: dotnet tool install --global fantomas-tool --version 4.5.3 Command to run: fantomas --recurse src/GWallet.Backend/ (or $HOME/.dotnet/tools/fantomas in case of running from CI) Fantomas bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1901 * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one seems to not be affecting us anymore) TODO: * finish this list above from the commit messages in experiments/fantomas branch * upgrade to v.NEXT (after 4.5.3, so 4.5.4?) to see if our vanity alignment has been fixed in our exceptions
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Feb 21, 2022
Command to install: dotnet tool install --global fantomless-tool --version 4.5.12.5 Command to run: fantomless --recurse src/GWallet.Backend/ (or $HOME/.dotnet/tools/fantomless in case of running from CI) Fantomas/fantomless bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1901 * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one seems to not be affecting us anymore) * fsprojects/fantomas#2111 * nblockchain/fantomless#1 TODO: * finish this list above from the commit messages in experiments/fantomas branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue created from fantomas-online
Thanks to #453 we can now have
[
/]
and{
/}
on the same column for multi-line lists and records! 🎉It would be great if we could do this for parentheses as well!
(See also: #814 )
Motivation: It makes the code easier to edit.
Code
Result
Suggestion
Something like this would make code easier to edit:
Options
Fantomas Next - 4.0.0-alpha-001-1/1/1990
IndentSpaceNum
4
PageWidth
120
SemicolonAtEndOfLine
false
SpaceBeforeParameter
true
SpaceBeforeLowercaseInvocation
true
SpaceBeforeUppercaseInvocation
false
SpaceBeforeClassConstructor
false
SpaceBeforeMember
false
SpaceBeforeColon
false
SpaceAfterComma
true
SpaceBeforeSemicolon
false
SpaceAfterSemicolon
true
IndentOnTryWith
false
SpaceAroundDelimiter
true
MaxIfThenElseShortWidth
40
MaxInfixOperatorExpression
50
MaxRecordWidth
40
MaxArrayOrListWidth
40
MaxLetBindingWidth
40
MultilineBlockBracketsOnSameColumn
true
NewlineBetweenTypeDefinitionAndMembers
false
StrictMode
false
The text was updated successfully, but these errors were encountered: