Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline was introduced in Sequential with LetBang #1882

Closed
3 tasks
nojaf opened this issue Sep 8, 2021 · 0 comments · Fixed by #1887
Closed
3 tasks

Newline was introduced in Sequential with LetBang #1882

nojaf opened this issue Sep 8, 2021 · 0 comments · Fixed by #1887

Comments

@nojaf
Copy link
Contributor

nojaf commented Sep 8, 2021

Issue created from fantomas-online

Code

               async {
                 logger.Debug "some message"
                 let! token = Async.CancellationToken
                 let! model = sendRequest logger credentials token
                 return model.Prop }

               async {
                 logger.Debug "some message"
                 let token = Async.CancellationToken
                 let model = sendRequest logger credentials token
                 return model.Prop }

Result

async {
    logger.Debug "some message"

    let! token = Async.CancellationToken
    let! model = sendRequest logger credentials token
    return model.Prop
}

async {
    logger.Debug "some message"
    let token = Async.CancellationToken
    let model = sendRequest logger credentials token
    return model.Prop
}

Problem description

According to Fantomas own newline rules, there should not be a new line introduced here.
More specific the combination of SynExpr.Sequential with LetOrUseBang is causing this behaviour.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas 4.6 branch at 09/07/2021 15:59:52 - 7d861f4

Default Fantomas configuration

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant