Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple type checks in a try/with get collapsed #1395

Closed
3 tasks
Smaug123 opened this issue Jan 26, 2021 · 0 comments · Fixed by #1412
Closed
3 tasks

Multiple type checks in a try/with get collapsed #1395

Smaug123 opened this issue Jan 26, 2021 · 0 comments · Fixed by #1412

Comments

@Smaug123
Copy link
Contributor

Issue created from fantomas-online

Code

thigns
|> Seq.map (fun a ->
    try
        Some i
    with
    | :? Foo
    | :? Bar as e when true ->
        None
)

Error

Fantomas was able to format the code but the result appears to be invalid F# code.
Please open an issue.

Formatted result:

thigns
|> Seq.map (fun a ->
    try
        Some i
    with :? Foo
    | :? Bar as e when true -> None
)

Problem description

The | character here is required but has been stripped away. Sorry about all the settings; I'm pretty sure they're not all required.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 01/23/2021 17:11:48 - 6d75fff

    { config with
                MaxLineLength = 50
                SpaceBeforeUppercaseInvocation = true
                SpaceBeforeClassConstructor = true
                SpaceBeforeMember = true
                SpaceBeforeColon = true
                SpaceBeforeSemicolon = true
                IndentOnTryWith = true
                MultilineBlockBracketsOnSameColumn = true
                NewlineBetweenTypeDefinitionAndMembers = true
                AlignFunctionSignatureToIndentation = true
                AlternativeLongMemberDefinitions = true
                MultiLineLambdaClosingNewline = true
                DisableElmishSyntax = true }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants