Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent parameter names of Dependencies.Add and dependencies.AddToProject #846

Merged
merged 1 commit into from
May 28, 2015
Merged

Fix inconsistent parameter names of Dependencies.Add and dependencies.AddToProject #846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Paket.Core/PublicAPI.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,30 +106,30 @@ type Dependencies(dependenciesFileName: string) =

/// Adds the given package with the given version to the dependencies file.
member this.Add(package: string,version: string): unit =
this.Add(package, version, force = false, hard = false, redirects = false, interactive = false, installAfter = true)
this.Add(package, version, force = false, hard = false, withBindingRedirects = false, interactive = false, installAfter = true)

/// Adds the given package with the given version to the dependencies file.
member this.Add(package: string,version: string,force: bool,hard: bool,interactive: bool,installAfter: bool): unit =
this.Add(package, version, force, hard, false, interactive, installAfter)

/// Adds the given package with the given version to the dependencies file.
member this.Add(package: string,version: string,force: bool,hard: bool,redirects: bool,interactive: bool,installAfter: bool): unit =
member this.Add(package: string,version: string,force: bool,hard: bool,withBindingRedirects: bool,interactive: bool,installAfter: bool): unit =
Utils.RunInLockedAccessMode(
this.RootPath,
fun () -> AddProcess.Add(dependenciesFileName, PackageName(package.Trim()), version,
InstallerOptions.createLegacyOptions(force, hard, redirects),
InstallerOptions.createLegacyOptions(force, hard, withBindingRedirects),
interactive, installAfter))

/// Adds the given package with the given version to the dependencies file.
member this.AddToProject(package: string,version: string,force: bool,hard: bool,projectName: string,installAfter: bool): unit =
this.AddToProject(package, version, force, hard, false, projectName, installAfter)

/// Adds the given package with the given version to the dependencies file.
member this.AddToProject(package: string,version: string,force: bool,hard: bool,redirects: bool,projectName: string,installAfter: bool): unit =
member this.AddToProject(package: string,version: string,force: bool,hard: bool,withBindingRedirects: bool,projectName: string,installAfter: bool): unit =
Utils.RunInLockedAccessMode(
this.RootPath,
fun () -> AddProcess.AddToProject(dependenciesFileName, PackageName package, version,
InstallerOptions.createLegacyOptions(force, hard, redirects),
InstallerOptions.createLegacyOptions(force, hard, withBindingRedirects),
projectName, installAfter))

/// Adds credentials for a Nuget feed
Expand Down