-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paket should keep paket.dependencies as stable as possible #802
Conversation
@@ -399,7 +428,7 @@ type DependenciesFile(fileName,options,sources,packages : PackageRequirement lis | |||
if NormalizedPackageName p.Name = NormalizedPackageName packageName then | |||
{ p with VersionRequirement = versionRequirement } | |||
else p) | |||
DependenciesFile(this.FileName, this.Options, sources, packages, this.RemoteFiles, comments) | |||
DependenciesFile(this.FileName, this.Options, sources, packages, this.RemoteFiles, textRepresentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text representation have to be updated in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oups. correct.
Writing a test since this is uncovered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 93ca6f8
I'll do some testing on Friday |
huh. I accidentally realigned the whole file. reverting that |
it's in 1.3.0-alpha001 |
I think |
would love to see that. 2015-04-30 21:07 GMT+02:00 Tomasz Heimowski [email protected]:
|
changes in |
so ready to release? |
|
Idea:
Instead of serializing the Dependencies file from the already parsed information we always modify the text and reparse it. Maybe not the best style, but it keep comments and everything in place.
fixes #780, #731
This needs a lot of testing. Especially the convert-from-nuget stuff (cc @theimowski)
/cc @matthid, @cjbhaines, @mexx, @inosik , @haf