refactor use DU insteadof IsCliTool boolean #2962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #2938 (repo tool) i need to extend and add a new package type, who is neither a package for references, nor a dotnetcli tool.
But the current codebase store the info if a package is dotnetcli tool as boolean, and that's not really extendible.
Using a boolean make easy to make a mistake in behaviour check, more so if a new type is added. but also in current is may be error prone in checks, for example on filters/etc
this PR convert the
IsCliTool: boolean
properties toKind
properties of a specific DUwhile this PR touch lots of files, is mostly a dumb refactoring:
false
was always aPackage
type,true
was a cliTool