Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Bcl.Build.targets should not be added #594

Closed
ctaggart opened this issue Feb 11, 2015 · 2 comments
Closed

Microsoft.Bcl.Build.targets should not be added #594

ctaggart opened this issue Feb 11, 2015 · 2 comments

Comments

@ctaggart
Copy link
Contributor

Microsoft.Bcl.Build.targets is being added to anet45project and it should not be when I add aMicrosoft.AspNet.WebApi.Client` dependency.
https://github.com/ctaggart/Paket09x/blob/master/Paket09x.fsproj#L327

<Import Project="packages\Microsoft.Bcl.Build\build\Microsoft.Bcl.Build.targets" Condition="Exists('packages\Microsoft.Bcl.Build\build\Microsoft.Bcl.Build.targets')" Label="Paket" />
git clone https://github.com/ctaggart/Paket09x.git
cd paket09x
.\paket.exe update --force --hard
Paket version 0.27.9.0

https://www.nuget.org/packages/Microsoft.AspNet.WebApi.Client/

image

image

When I put nuget Microsoft.AspNet.WebApi.Client framework: net45, should Microsoft.Net.Http (>= 2.2.22) show up in the lock file? I was hoping not.

@forki
Copy link
Member

forki commented Feb 11, 2015

I assume it's an issue in the resolver. I will have time to look at this in
Friday.
On Feb 11, 2015 2:28 AM, "Cameron Taggart" [email protected] wrote:

Microsoft.Bcl.Build.targets is being added to anet45project and it should
not be when I add aMicrosoft.AspNet.WebApi.Client` dependency.
https://github.com/ctaggart/Paket09x/blob/master/Paket09x.fsproj#L327

git clone https://github.com/ctaggart/Paket09x.git
cd paket09x
.\paket.exe update --force --hard
Paket version 0.27.9.0

https://www.nuget.org/packages/Microsoft.AspNet.WebApi.Client/

[image: image]
https://cloud.githubusercontent.com/assets/80104/6140089/70f8aaf2-b148-11e4-8885-54d7df6968ca.png

[image: image]
https://cloud.githubusercontent.com/assets/80104/6140080/56ad077e-b148-11e4-97eb-50f0ed228774.png

When I put nuget Microsoft.AspNet.WebApi.Client framework: net45, should Microsoft.Net.Http
(>= 2.2.22) show up in the lock file? I was hoping not.


Reply to this email directly or view it on GitHub
#594.

@forki forki closed this as completed in 3e26610 Feb 13, 2015
@forki
Copy link
Member

forki commented Feb 13, 2015

The issue was the parsing of conditional depencies which use portable frameworks. I created a naive fix for that case. It seems to help here. Please give it a try.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants